-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Fix Callback Tensor Inputs of the SDXL Controlnet Inpaint and Img2img Pipelines are missing "controlnet_image". #10880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Callback Tensor Inputs of the SDXL Controlnet Inpaint and Img2img Pipelines are missing "controlnet_image". #10880
Conversation
|
I've noticed that pipelines related to |
|
@yiyixuxu @sayakpaul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @CyberVy
change looks good to me!
|
can you run |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@yiyixuxu Thank you! |
The checks failed again because of the same reason, although I've done the things above. Is there something wrong with the checks? Or did I do something wrong? |
|
@CyberVy Hi, are you using windows? |
|
seems the tests are passing now, so no problem, just update the branch and we're got to go after the tests pass, if they don't pass are you ok if I finish it so we can merge? |
Thank you. The checks passed.:) |
|
I think there is no problem, can we merge now? @asomoza |
|
oh I though it was good but now I see that (probably because of the make style) two more files were added which aren't related to this PR. Can you remove them please? |
OMG. Yes, it's because of make style. |
|
you deleted them, what I meant was to remove them from the tracking, you can just discard the changes to those two files. |
🙏Sorry, this is my first PR, so I'm not familar with it. Can I create those deleted files by copying them from the main branch? |
No problem, we all had a first PR so no worries.
you should be able to do this: or you can also revert your last commit and unstage them. but essentially it's the same as what you're proposing, just restore the files from main. |
|
@asomoza Now only 4 files related to this PR has changed. |
I will fix the other bugs I've mentioned before as soon as possible. |
|
thanks a lot! |
The properties
_callback_tensor_inputsofStableDiffusionXLControlNetImg2ImgPipeline,StableDiffusionXLControlNetInpaintPipeline,StableDiffusionXLControlNetUnionImg2ImgPipeline,StableDiffusionXLControlNetUnionInpaintPipelineare missing an important elementcontrolnet_image, which makes it impossible to retrievecontrolnet_imagefromcallback_kwargsofcallback_on_step_end.This PR is to fix this issue.